From 3c7997f1f7f270fa7dd04dac0d2cf63de1e2c245 Mon Sep 17 00:00:00 2001 From: Kenneth Barbour Date: Thu, 29 Nov 2018 21:09:11 -0500 Subject: [PATCH] initialized buffer in test and made room for null terminator --- src/HttpResponse.cpp | 18 +++++++++--------- test/test_HttpResponse.cpp | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/HttpResponse.cpp b/src/HttpResponse.cpp index 3afbe25..804f976 100644 --- a/src/HttpResponse.cpp +++ b/src/HttpResponse.cpp @@ -3,17 +3,17 @@ /** * TODO: this is the only constructor really needed unless _TEST_ */ -HttpResponse::HttpResponse(Stream& buffer): - content(&buffer), - code(200), - reason(), - httpver() +HttpResponse::HttpResponse(Stream& buffer): + content(&buffer), + code(200), + reason(), + httpver() {}; -HttpResponse::HttpResponse(): - code(200), +HttpResponse::HttpResponse(): + code(200), reason(), - httpver() + httpver() {}; @@ -21,7 +21,7 @@ const char * HttpResponse::setReason(const char * reason) { if (this->reason != nullptr) free(this->reason); if (reason == nullptr) return this->reason = nullptr; - this->reason = (char *) malloc(strlen(reason)); + this->reason = (char *) malloc(strlen(reason) + 1); strcpy(this->reason, reason); return this->reason; diff --git a/test/test_HttpResponse.cpp b/test/test_HttpResponse.cpp index 1bdb2f4..e7b4449 100644 --- a/test/test_HttpResponse.cpp +++ b/test/test_HttpResponse.cpp @@ -35,7 +35,7 @@ TEST_CASE("Unset reason", "[HttpResponse]") TEST_CASE("HttpResponse send", "[HttpResponse]") { uint8_t response_buffer[100] = "AAAABBBBCCCCDDDDEEEE"; - uint8_t print_buffer[100]; + uint8_t print_buffer[100] = {}; Buffer message(response_buffer, 100); Buffer client(print_buffer, 100); HttpResponse r(message);