initialized buffer in test and made room for null terminator

documentation
Kenneth Barbour 2018-11-29 21:09:11 -05:00
parent 42b1566785
commit 3c7997f1f7
2 changed files with 10 additions and 10 deletions

View File

@ -3,17 +3,17 @@
/** /**
* TODO: this is the only constructor really needed unless _TEST_ * TODO: this is the only constructor really needed unless _TEST_
*/ */
HttpResponse::HttpResponse(Stream& buffer): HttpResponse::HttpResponse(Stream& buffer):
content(&buffer), content(&buffer),
code(200), code(200),
reason(), reason(),
httpver() httpver()
{}; {};
HttpResponse::HttpResponse(): HttpResponse::HttpResponse():
code(200), code(200),
reason(), reason(),
httpver() httpver()
{}; {};
@ -21,7 +21,7 @@ const char * HttpResponse::setReason(const char * reason)
{ {
if (this->reason != nullptr) free(this->reason); if (this->reason != nullptr) free(this->reason);
if (reason == nullptr) return this->reason = nullptr; if (reason == nullptr) return this->reason = nullptr;
this->reason = (char *) malloc(strlen(reason)); this->reason = (char *) malloc(strlen(reason) + 1);
strcpy(this->reason, reason); strcpy(this->reason, reason);
return this->reason; return this->reason;

View File

@ -35,7 +35,7 @@ TEST_CASE("Unset reason", "[HttpResponse]")
TEST_CASE("HttpResponse send", "[HttpResponse]") TEST_CASE("HttpResponse send", "[HttpResponse]")
{ {
uint8_t response_buffer[100] = "AAAABBBBCCCCDDDDEEEE"; uint8_t response_buffer[100] = "AAAABBBBCCCCDDDDEEEE";
uint8_t print_buffer[100]; uint8_t print_buffer[100] = {};
Buffer message(response_buffer, 100); Buffer message(response_buffer, 100);
Buffer client(print_buffer, 100); Buffer client(print_buffer, 100);
HttpResponse r(message); HttpResponse r(message);